-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Korean: leftover non-name test failures #42
Comments
Ok. I'll start looking into the list. |
Updated list: korean_nonames_tests.log I noticed this:
This is a result of the "kkk -> kk" replacement rule. Is "kkk" legit here? |
No. "kkk" is never allowed in the current rules. It always has to be turned into "kk" |
New test log. |
I have found a few names that had split digraph, which I have corrected. All remaining ones (139) look like sentences with proper names which won't transliterate correctly anyway, or possibly legitimate errors on names. |
More fixes in #91. Updated list: |
All tests pass now. Closing. |
@hyoungl Attached here is a list of the last failing Korean tests from the test strings you provided. I thought it would be more practical for you to review the log as a whole and comment on the individual issues, as many of them seem related to personal names.
korean_tests.log
Thanks.
The text was updated successfully, but these errors were encountered: