Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean: leftover non-name test failures #42

Closed
scossu opened this issue Aug 3, 2023 · 7 comments
Closed

Korean: leftover non-name test failures #42

scossu opened this issue Aug 3, 2023 · 7 comments
Assignees
Milestone

Comments

@scossu
Copy link
Collaborator

scossu commented Aug 3, 2023

@hyoungl Attached here is a list of the last failing Korean tests from the test strings you provided. I thought it would be more practical for you to review the log as a whole and comment on the individual issues, as many of them seem related to personal names.
korean_tests.log

Thanks.

@hyoungl
Copy link
Collaborator

hyoungl commented Aug 3, 2023

Ok. I'll start looking into the list.

@scossu
Copy link
Collaborator Author

scossu commented Sep 4, 2023

Updated list: korean_nonames_tests.log

I noticed this:

- Am yebang: 5-kaji saekkal ŭl mŏgŏra
+ Am yebang: 5-kaji saekkkal ŭl mŏgŏra
?                        +
 : S2R transliteration error for korean_nonames!
Original: 암 예방 : 5가지 색깔 을 먹어라

This is a result of the "kkk -> kk" replacement rule. Is "kkk" legit here?

@hyoungl
Copy link
Collaborator

hyoungl commented Sep 5, 2023

No. "kkk" is never allowed in the current rules. It always has to be turned into "kk"

@scossu
Copy link
Collaborator Author

scossu commented Nov 6, 2023

test_korean.log

New test log.

@scossu
Copy link
Collaborator Author

scossu commented Jan 13, 2024

I have found a few names that had split digraph, which I have corrected.

All remaining ones (139) look like sentences with proper names which won't transliterate correctly anyway, or possibly legitimate errors on names.

test_korean.log

@scossu
Copy link
Collaborator Author

scossu commented Jan 14, 2024

More fixes in #91. Updated list:

test_korean-20240113.log

@scossu
Copy link
Collaborator Author

scossu commented Feb 22, 2024

All tests pass now. Closing.

@scossu scossu closed this as completed Feb 22, 2024
@scossu scossu added this to the Phase 2 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants