Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename serde1 feature to serde #6

Open
lcnr opened this issue Feb 19, 2020 · 1 comment
Open

rename serde1 feature to serde #6

lcnr opened this issue Feb 19, 2020 · 1 comment
Labels
C-enhancement New feature or request help wanted Extra attention is needed P-low Low priority

Comments

@lcnr
Copy link
Owner

lcnr commented Feb 19, 2020

The serde feature is currently called serde1.

This because serde derive requires that the crate serde is imported as serde
and features share the same namespace with dependencies.

As I need to explicitly enable glutin/serde I currently use serde1 as the feature flag and
emit a compilation error in case serde is used without serde1.
@lcnr lcnr added C-enhancement New feature or request help wanted Extra attention is needed labels Feb 19, 2020
@lcnr
Copy link
Owner Author

lcnr commented Feb 19, 2020

for reference: serde-rs/serde#953

@lcnr lcnr added the P-low Low priority label Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request help wanted Extra attention is needed P-low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lcnr