Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centerfair layout is broken #69

Closed
mrmouss opened this issue Nov 8, 2014 · 9 comments
Closed

Centerfair layout is broken #69

mrmouss opened this issue Nov 8, 2014 · 9 comments

Comments

@mrmouss
Copy link
Contributor

mrmouss commented Nov 8, 2014

I get the following error
"Oops, an error happened!
/home/mouss/.config/awesome/lain/layout/centerfair.lua:98: attempt to index field '?' (a nil value'"

@lcpz
Copy link
Owner

lcpz commented Nov 8, 2014

When you get an error, you should tell how to reproduce it too.

Assuming that this happens when you kill all clients in your desktop, tell me if it works again in ada3be2.

@mrmouss
Copy link
Contributor Author

mrmouss commented Nov 8, 2014

The error produces when you a tag has a centerfair layout. I reload awesome and when I switch to the concerned tag the error produces.
Now the error doesn't produce but the layout isn't working as it's expected to be. Now the client is taking all the screen while it should only take half of it according to:
lain.layout.centerfair.nmaster = 2
lain.layout.centerfair.ncol = 1

@lcpz
Copy link
Owner

lcpz commented Nov 8, 2014

Nope, that's how termfair works.

centerfair always centers.

@lcpz
Copy link
Owner

lcpz commented Nov 10, 2014

Is this solved or not?

@mrmouss
Copy link
Contributor Author

mrmouss commented Nov 10, 2014

The error did indeed disappear but the layout is not working as it should be at all. The first client is taking all the work area.

@lcpz
Copy link
Owner

lcpz commented Nov 10, 2014

Yes, and I told you that you're wrong.

In centerfair it's correct that the first client is taking all the work area.

The behaviour you're looking for is in termfair.

@mrmouss
Copy link
Contributor Author

mrmouss commented Nov 10, 2014

Here's what's written in the description:
2014-11-10 18_29_12-layouts copycat-killer_lain wiki

@lcpz
Copy link
Owner

lcpz commented Nov 11, 2014

Yeah, and I still can't see your point. I'll look at your correction tomorrow.

@lcpz
Copy link
Owner

lcpz commented Nov 14, 2014

Solved in e381fda. Finally understood. Thanks to @mbennehar.

@lcpz lcpz closed this as completed Nov 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants