Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open remote resources to external repositories other than PhysioNet.org ? #7

Open
lcsrodriguez opened this issue Jul 22, 2022 · 1 comment
Open

Open remote resources to external repositories other than PhysioNet.org ? #7

lcsrodriguez opened this issue Jul 22, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed NEW FEATURE Feature (critical or minor) to be added in the next version (add description) question Further information is requested

Comments

@lcsrodriguez
Copy link
Owner

Current state-of-the-art of the app : users can only download resources from remote repositories of https://physionet.org/files/

Issue : if users want to use a remote resource from another domain, they are blocked by the inner condition of the program.
@lcsrodriguez lcsrodriguez added enhancement New feature or request help wanted Extra attention is needed question Further information is requested NEW FEATURE Feature (critical or minor) to be added in the next version (add description) labels Jul 22, 2022
@lcsrodriguez
Copy link
Owner Author

Solutions

  1. Set up a white-list of remote repositories domains for security reasons
  2. Add the possibility to modify this white-list online (by initiating a PR)
  3. Check at each .add_record() call the belonging of the domain to the WL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed NEW FEATURE Feature (critical or minor) to be added in the next version (add description) question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lcsrodriguez