Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can we change black background with clear color or semi transparant black color? #35

Open
jignesh133 opened this issue Aug 9, 2018 · 2 comments · May be fixed by #47
Open

can we change black background with clear color or semi transparant black color? #35

jignesh133 opened this issue Aug 9, 2018 · 2 comments · May be fixed by #47

Comments

@jignesh133
Copy link

Expected behavior

it allowed to change background colour based on app theme

Actual behavior

it showing in only Black color

Steps to reproduce the behavior

Add Colour type variable in configuration so user can change the colour based on his requirements
@jignesh133 jignesh133 changed the title can we change black background with clear colour or semi transparant black colour? can we change black background with clear color or semi transparant black colour? Aug 28, 2018
@jignesh133 jignesh133 changed the title can we change black background with clear color or semi transparant black colour? can we change black background with clear color or semi transparant black color? Aug 28, 2018
@LcTwisk
Copy link
Owner

LcTwisk commented Sep 8, 2018

I think this would be a nice addition to the library ;) Feel free to open a PR where the backgroundColor/theme is configurable 👍

@swesteme swesteme linked a pull request Jan 15, 2019 that will close this issue
Open
@swesteme
Copy link

swesteme commented Nov 5, 2019

@LcTwisk maybe you could check out the pull request #47? The background colour can be changed now (see updates in example project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed a few issues and implemented features swesteme/SimpleImageViewer
3 participants
@LcTwisk @jignesh133 @swesteme