Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

npm release contains .nyc-output json files #681

Closed
trgwii opened this issue Nov 17, 2020 · 2 comments · Fixed by #682
Closed

npm release contains .nyc-output json files #681

trgwii opened this issue Nov 17, 2020 · 2 comments · Fixed by #682
Assignees
@UziTech

Comments

@trgwii
Copy link

trgwii commented Nov 17, 2020

Seems like the latest npm release of this module (2.2.1) contains around 30MB of something that looks like test coverage debug files?
windirstat_2020-11-17_13-53-07
I assume this is some kind of deployment mistake that should be mitigated with package.json "files" field or .npmignore
Please fix for next release!
@jsumners
Copy link
Member

I would just remove the .npmignore and let the .gitignore handle it.

@UziTech UziTech mentioned this issue Nov 18, 2020
Merged
@jsumners
Copy link
Member

⚠️ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.

Please include a minimal reproducible example
when opening a new issue.

@ldapjs ldapjs locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@UziTech UziTech

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove .npmignore
3 participants
@UziTech @jsumners @trgwii