Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

Weird behaviour when selecting a cohort in explore tab #225

Closed
WiseIndian opened this issue Oct 27, 2021 · 0 comments · Fixed by #226
Closed

Weird behaviour when selecting a cohort in explore tab #225

WiseIndian opened this issue Oct 27, 2021 · 0 comments · Fixed by #226
Labels
bug Something isn't working

Comments

@WiseIndian
Copy link

We noticed this bug in the interface with @jimmydjabali.
We went through the following scenario that lead to a bug.
We were in the explore tab. We selected a cohort by clicking on it. The second action we performed was drag and dropping a concept in the inclusion criteria.
What appeared in the inclusion criteria was the cohort and not the concept name.
Jimmy concluded that clicking on the cohort saves it in a variable which determines what cohort is being dragged at the moment. If this variable is non empty it will be used to fill the inclusion criteria on the next concept drag and drop.
One solution could be to empty this variable by the end of the cohort click event callback if this variable contains the same value as the cohort clicked.
Another solution could be to avoid filling this variable on a simple click event.

@WiseIndian WiseIndian added the bug Something isn't working label Oct 27, 2021
@jimmydjabali jimmydjabali linked a pull request Oct 27, 2021 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant