Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Doors/gates that are open are replaced when repaired #9817

Open
4 of 5 tasks
tecnobrat opened this issue Mar 3, 2024 · 2 comments
Open
4 of 5 tasks

[BUG] Doors/gates that are open are replaced when repaired #9817

tecnobrat opened this issue Mar 3, 2024 · 2 comments
Labels
Bug Gotta squash 'em all!

Comments

@tecnobrat
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Are you using the latest MineColonies Version?

  • I am running the latest alpha version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.20.1

MineColonies Version

1.20.1-1.1.494-BETA

Structurize Version

1.20.1-1.0.701-BETA

Related Mods and their Versions

Forge: 47.2.17
BlockUI: 1.20.1-1.0.139-BETA
Domum Ornamentum: 1.20-1.0.160-BETA

Current Behavior

When you repair a building that has doors or gates that are in a different state (open instead of closed) than on the blueprint, it replaces them. I believe it happens for trapdoors, or any item that can be "opened".

Expected Behavior

It should not replace doors/gates/trapdoors that are in the correct physical placement, regardless of their open/closed state.

Reproduction Steps

  1. Build a building.
  2. Open the door.
  3. Repair the building.
  4. It replaces the door.

Logs

No log

Anything else?

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
@tecnobrat tecnobrat added the Bug Gotta squash 'em all! label Mar 3, 2024
@tecnobrat
Copy link
Author

tecnobrat commented Mar 9, 2024

This also happens with furnaces and beehives. I assume anything with a different current state than the default.

@Raycoms
Copy link
Contributor

Raycoms commented Mar 10, 2024

It's not a trivial thing to handle because sometimes state (e.g. type) completely changes and the block needs to be replaced. So it would have to be on a heavy case-by-case basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Gotta squash 'em all!
Projects
None yet
Development

No branches or pull requests

2 participants