Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 2FA authentication #40

Closed
hmdfsn opened this issue Sep 4, 2019 · 0 comments
Closed

Support 2FA authentication #40

hmdfsn opened this issue Sep 4, 2019 · 0 comments
Labels
bug Something isn't working enhancement Ask to enhance an existing feature

Comments

@hmdfsn
Copy link
Collaborator

hmdfsn commented Sep 4, 2019

Description of issue or feature request

le-git-imate can not perform a webui commit is the user enables two-factor authentication (2FA) .
This could be addressed in accordance with #13 and #28 .

Current behavior

Once a user enables 2FA, they can not use password for the authentication and instead they must create a personal token to use as a password when authenticating to GitHub.

However, the current version of le-git-imate uses the token only to authenticate GitHub/GitLab APIs and the authentication for git-receive-pack protocol is done by password. As a result, if a user enables 2FA, they can not use the le-git-imate extension to sign the webui commits.

Expected behavior

le-git-imate must use the personal token for any authentication which means the basicAuth should be replaced with a token-based approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Ask to enhance an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant