Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sum(dim=2) for dot-product #24

Closed
jnhwkim opened this issue Oct 6, 2020 · 1 comment
Closed

Add sum(dim=2) for dot-product #24

jnhwkim opened this issue Oct 6, 2020 · 1 comment

Comments

@jnhwkim
Copy link

jnhwkim commented Oct 6, 2020

I believe .sum(dim=2) should be added to the below line:

Stand-Alone-Self-Attention/attention.py

Line 48 in a983f0f

out = q_out * k_out

for dot-product in Equation 2 in the paper.
@jnhwkim
Copy link
Author

jnhwkim commented Oct 6, 2020

Duplicated with #10.

@jnhwkim jnhwkim closed this as completed Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jnhwkim