Only count distinct (domain+field) sniffs once #8
Conversation
This is a proposed behavior change to only increment the sniff count once, per distinct "sniff-domain/sniffed-field". The change alters the "inputSniffed" message handler to -update- (rather than -insert-) sniff details, if the domain+fieldName+xpath already exists. Included is a modification to setBadge() to display the sniff count when the badge is yellow (i.e. when there are sniffs, but no leaky requests).
background_scripts/background.js
Outdated
| }, | ||
| timeStamp: sniffDetails.timeStamp, | ||
| }); | ||
| const previouslySniffedDetails=sniffs[msgTabId][sniff.domain]["details"].find(d => d.inputField.fieldName===sniffDetails.fieldName && d.inputField.xpath===sniffDetails.xpath); |
There was a problem hiding this comment.
Is it possible to do this look up without find? For instance by using fieldName and xpath as keys?
sniffs[msgTabId][sniff.domain]["details"][sniffDetails.fieldName][sniffDetails.xpath], or something similar.
There was a problem hiding this comment.
Can we leave a space before and after the =:
const previouslySniffedDetails=sniffs... -> const previouslySniffedDetails = sniffs...
There was a problem hiding this comment.
tbh, I'm not aware of a better alternative to find in this case, and I'm not familiar with any way to use keys that way.
So please feel free to alter it however you feel works best.
There was a problem hiding this comment.
Sure. Thanks for the contribution. We'll take it from there.
|
I think this is reasonable behavior change. There are pros and cons to both approaches, but we'll be happy to merge this once the comments are addressed. |
This is a proposed behavior change to only increment the sniff count once, per distinct "sniff-domain/sniffed-field".
The change alters the "inputSniffed" message handler to -update- (rather than -insert-) sniff details, if the domain+fieldName+xpath already exists.
Included is a modification to setBadge() to display the sniff count when the badge is yellow (i.e. when there are sniffs, but no leaky requests).