Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to mark terms as deprecated #63

Open
RobertOdrowaz opened this issue Mar 15, 2023 · 1 comment
Open

Option to mark terms as deprecated #63

RobertOdrowaz opened this issue Mar 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@RobertOdrowaz
Copy link
Member

Having an option to mark some terms as deprecated before removing them from poeditor while they are stil in use in the app would be useful. Poeditor allows assigning tags to terms so propagating tag "deprecated" to @depreacted in the code would probably be best.

This feature might not be simple or even possible because (in this form):

  1. I'm not sure if those tags are event available though poeditor api
  2. Probably requires editing generated .dart files since I don't think there is a way to mark term as deprecated in the .arb format
@RobertOdrowaz RobertOdrowaz added the enhancement New feature or request label Mar 15, 2023
@Albert221
Copy link
Member

Albert221 commented Mar 15, 2023

POEditor's JSON export doesn't give information about tags:

POEditorExport
{
        "term": "testPlural",
        "definition": {
            "one": "One {count}",
            "other": "Many {count}s"
        },
        "context": "",
        "term_plural": "plural",
        "reference": "",
        "comment": ""
},

It is possible to fetch this tags info from POE API: https://poeditor.com/docs/api#terms_list

And yes, your 2. point is correct. This will require modifying the flutter gen-l10n output Dart files. So we either make poe2arb also run the flutter gen-l10n command or create a separate command that serves solely for spicing the Dart files with (for now) @deprecateds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants