Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funnel Chart not supported #50

Closed
KostasKostogloy opened this issue Nov 14, 2023 · 5 comments
Closed

Funnel Chart not supported #50

KostasKostogloy opened this issue Nov 14, 2023 · 5 comments
Labels

Comments

@KostasKostogloy
Copy link

KostasKostogloy commented Nov 14, 2023

Apex Docs: https://apexcharts.com/docs/chart-types/funnel-chart/

Chart type introduced on v3.41.0 https://github.com/apexcharts/apexcharts.js/releases/tag/v3.41.0
(most recent version being v3.44.0)

This package is using v3.36.2 https://github.com/leandrocfe/filament-apex-charts/blob/master/dist/apexcharts.js

@leandrocfe
Copy link
Owner

I'll update it. Thank you

@leandrocfe
Copy link
Owner

@KostasKostogloy, could you update composer and try it please?
https://github.com/leandrocfe/filament-apex-charts/tree/3.0.2

@KostasKostogloy
Copy link
Author

@leandrocfe it seems to work fine 👍. Thanks

I had a workaround for datalabels formatting (#16 (comment)) which seems to be broken now. You did a small refactor from what I can see.

Unfortunately now I am stuck with v3.0.1 😅

@leandrocfe
Copy link
Owner

@KostasKostogloy, could you try the new version please?
https://github.com/leandrocfe/filament-apex-charts/tree/3.1.0

@KostasKostogloy
Copy link
Author

@leandrocfe It works fine, good job 👍

A few updates on my code were needed with the new version.

  1. The type of $chartId changed from string to ?string. eg. protected static ?string $chartId = 'yourChartId';. I updated my charts. Heads up, your code examples still use string.
  2. You now need to register the plugin on your PanelProvider (which you already added on the documentation).

Thanks for the update and happy new year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants