Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(init/data/string/*): implement decidable equality for strings without using tactics #204

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

JLimperg
Copy link
Collaborator

The decidable equality instance for strings
(string.has_decidable_equality) was previously defined via the
mk_dec_eq_instance tactic. However, we'd like to be able to use this
instance in init.meta.*, which creates import cycles. This commit
therefore reimplements the instance without using tactics.

…s without using tactics

The decidable equality instance for strings
(`string.has_decidable_equality`) was previously defined via the
`mk_dec_eq_instance` tactic. However, we'd like to be able to use this
instance in init.meta.*, which creates import cycles. This commit
therefore reimplements the instance without using tactics.
@JLimperg
Copy link
Collaborator Author

This change is fully backwards-compatible unless someone imports init.data.string.instances directly (and why would you?). Should I still write a changes entry?

@gebner
Copy link
Member

gebner commented Apr 28, 2020

LGTM. The only important thing is that the decidability instance still has exactly the same name and type, because it is override in the VM.

If somebody imports init.data.string.instances, they're on their own.

@gebner gebner merged commit f1fc405 into master Apr 28, 2020
@JLimperg JLimperg deleted the decidable-eq-string branch April 28, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants