[Merged by Bors] - fix(src/CMakeLists): remove useless setting of _GLIBCXX_USE_CXX11_ABI with MinGW
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained in [this comment](leanprover/lean3#930 (comment)), forcing the value `_GLIBCXX_USE_CXX11_ABI` doesn't make any sense for what it was originally introduced, it's useless: with this patch I can compile with MinGW for both C++ string ABIs without problems.
gebner
changed the title
_GLIBCXX_USE_CXX11_ABI with MinGW_GLIBCXX_USE_CXX11_ABI with MinGW
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jun 2, 2020
…I` with MinGW (#293) As explained in [this comment](leanprover/lean3#930 (comment)), forcing the value `_GLIBCXX_USE_CXX11_ABI` doesn't make any sense for what it was originally introduced, and it's also useless: with this patch I can compile with MinGW for both C++ string ABIs without problems. Patch used in JuliaPackaging/Yggdrasil#1103 to build LEAN with [BinaryBuilder](https://binarybuilder.org/)
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
_GLIBCXX_USE_CXX11_ABI with MinGW_GLIBCXX_USE_CXX11_ABI with MinGW
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in this comment,
forcing the value
_GLIBCXX_USE_CXX11_ABIdoesn't make any sense for what itwas originally introduced, and it's also useless: with this patch I can compile with
MinGW for both C++ string ABIs without problems.
Patch used in JuliaPackaging/Yggdrasil#1103 to build LEAN with BinaryBuilder