Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(library/init/meta/widget/interactive_expr): make widget look more like current tactic state #303

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(library/init/meta/widget/interactive_expr): make widget look more like current tactic state #303

wants to merge 1 commit into from

Conversation

gebner
Copy link
Member

@gebner gebner commented Jun 8, 2020

  • Remove large margin at top and bottom.
  • Do not align colons. This was awkward when assumptions had long names like in the image.

widget_ui_302

cc @EdAyers

@gebner
Copy link
Member Author

gebner commented Jun 8, 2020

bors merge

bors bot pushed a commit that referenced this pull request Jun 8, 2020
@gebner
chore(library/init/meta/widget/interactive_expr): make widget look mo…
8439875 
…re like current tactic state (#303)

- Remove large margin at top and bottom.
- Do not align colons.  This was awkward when assumptions had long names like in the image.

![widget_ui_302](https://user-images.githubusercontent.com/313929/84054804-36fd5180-a9b4-11ea-9c1e-5501588ea95b.png)

cc @EdAyers
@EdAyers
Copy link
Member

EdAyers commented Jun 8, 2020

Looks good to me! I hope you found it roughly straightforward to understand and modify the code.

@bors
Copy link

bors bot commented Jun 8, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(library/init/meta/widget/interactive_expr): make widget look more like current tactic state [Merged by Bors] - chore(library/init/meta/widget/interactive_expr): make widget look more like current tactic state Jun 8, 2020
@bors bors bot closed this Jun 8, 2020
@bors bors bot deleted the widget_ui branch June 8, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gebner @EdAyers