Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(library/init/algebra/classes): put is_strict_total_order in Prop #327

Closed

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 13, 2020

No description provided.

@gebner
Copy link
Member

gebner commented Jun 13, 2020

I'm half surprised that somebody actually uses this file. This was part of the never realized algebraic normalizer. It's not really used in core either, so you could move it to mathlib fairly easily, if you want.

bors merge

bors bot pushed a commit that referenced this pull request Jun 13, 2020
@urkud
Copy link
Member Author

urkud commented Jun 13, 2020

I don't use it. I was reading order/basic and noticed that we have is_strict_total_order' in mathlib.

@bryangingechen
Copy link
Collaborator

I think @digama0 suggested moving all of this order stuff out of core. #288 was sort of a preliminary step, but I ran out of steam.

@bors
Copy link

bors bot commented Jun 13, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(library/init/algebra/classes): put is_strict_total_order in Prop [Merged by Bors] - fix(library/init/algebra/classes): put is_strict_total_order in Prop Jun 13, 2020
@bors bors bot closed this Jun 13, 2020
@urkud urkud deleted the is-strict-total-order-prop branch October 22, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants