[Merged by Bors] - fix(init/meta/well_founded_tactics): alternate mutual sizeof #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue in which mutual recursions cannot call other functions if they have an index too large, because the default sizeof instance for psum penalizes lots of `psum.inr` constructors.
|
I thought the general plan was to get rid of the default termination measure altogether: #288 But in the absence of progress on the other PR, this seems like a good improvement. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 5, 2020
This fixes an issue in which mutual recursions cannot call other functions if they have an index too large, because the default sizeof instance for psum penalizes lots of `psum.inr` constructors. Zulip: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/well.20founded.20relation.20problem.20with.203.20mutual.20recursion/near/215578029
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
|
@gebner This actually changes the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in which mutual recursions cannot call other
functions if they have an index too large, because the default sizeof
instance for psum penalizes lots of
psum.inrconstructors.Zulip: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/well.20founded.20relation.20problem.20with.203.20mutual.20recursion/near/215578029