[Merged by Bors] - perf(library/type_context): enable type class cache in nested resolution problems #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
reviewed
Nov 20, 2020
| @@ -2415,8 +2415,7 @@ bool type_context_old::mk_nested_instance(expr const & m, expr const & m_type) { | |||
|
|
|||
| // HACK(gabriel): do not reuse type-class cache for nested resolution problems | |||
| // For one example that easily breaks, see the default field values in `init/control/lawful.lean` | |||
| // TODO(gabriel): allow local caching | |||
There was a problem hiding this comment.
What about the example that easily break, mentioned above this line?
There was a problem hiding this comment.
That's when you reuse the cache. We don't do this here. We start with an empty cache (as opposed to no caching at all).
|
bors merge |
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504.
Well, not completely. The cache is still reset between different nested resolution problems during unification. But at least it makes diamonds much less of a problem.