[Merged by Bors] - fix(checker/text_import): make leanchecker agree with external tc #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to `text_import.cpp` checks the line for parse errors after parsing, so we don't accidentally let malformed lines pass. The change to the kernel removes the check for anonymous names in lambda/let/pi. Since these are used only for pretty printing it should not affect soundness. An alternative approach would be to automatically generate a fresh name when the given name is anonymous.
dwrensha
reviewed
May 10, 2021
src/checker/text_import.cpp
Outdated
| @@ -224,6 +226,10 @@ struct text_importer { | |||
| } else { | |||
| throw exception(sstream() << "unknown command: " << cmd); | |||
| } | |||
| in >> std::ws; | |||
There was a problem hiding this comment.
On MacOS, this line (in >> std::ws;) is causing in.fail() to flip to true.
There was a problem hiding this comment.
is in.eof() true before the call to std::ws?
|
Thanks! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 10, 2021
The change to `text_import.cpp` checks the line for parse errors after parsing, so we don't accidentally let malformed lines pass. The change to the kernel removes the check for anonymous names in lambda/let/pi. Since these are used only for pretty printing it should not affect soundness. An alternative approach would be to automatically generate a fresh name when the given name is anonymous. See https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/rejected.20by.20leanchecker.20but.20accepted.20by.20trepplein
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to
text_import.cppchecks the line for parse errors afterparsing, so we don't accidentally let malformed lines pass.
The change to the kernel removes the check for anonymous names in
lambda/let/pi. Since these are used only for pretty printing it should
not affect soundness. An alternative approach would be to automatically
generate a fresh name when the given name is anonymous.
See https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/rejected.20by.20leanchecker.20but.20accepted.20by.20trepplein