This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
only check for .xz archives #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gebner
reviewed
Aug 16, 2020
mathlibtools/lib.py
Outdated
| @@ -149,7 +149,7 @@ def get_mathlib_archive(rev: str, url:str = '', force: bool = False, | |||
| """ | |||
|
|
|||
| # we check for xz archives first | |||
| fnames = [rev + '.tar.xz', rev + '.tar.gz', rev + '.tar.bz2'] | |||
| fnames = [rev + '.tar.xz'] | |||
There was a problem hiding this comment.
There is no point in keeping a list with only one element, this function must be simplified more drastically.
There was a problem hiding this comment.
I pushed a commit that addressed this.
eric-wieser
reviewed
Oct 8, 2020
eric-wieser
reviewed
Oct 8, 2020
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
approved these changes
Oct 8, 2020
eric-wieser
reviewed
Oct 8, 2020
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
PatrickMassot
pushed a commit
that referenced
this pull request
Oct 10, 2020
only check for .xz archives Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't look on github for olean archives, and don't look for .gz and .bz2 archives anymore.