Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing messages if wrong version of Lean vscode extension used. #224

Closed
EdAyers opened this issue Jul 18, 2022 · 3 comments · Fixed by leanprover/lean4#1382
Closed

Confusing messages if wrong version of Lean vscode extension used. #224

EdAyers opened this issue Jul 18, 2022 · 3 comments · Fixed by leanprover/lean4#1382
Labels
bug Something isn't working

Comments

@EdAyers
Copy link
Contributor

EdAyers commented Jul 18, 2022

If I open a Lean 4 project in vscode and forget to deactivate the lean 3 extension. The output window pops open with a message Watchdog error: Cannot read LSP request: Invalid header field: .... I've also observed panics in some cases.

This is happening because the Lean 4 server is receiving Lean 3 language server messages.
I think that the user experience could be greatly improved by having both the vscode lean 3 extension and lean 4 be aware of the other protocol and send a friendly message to the user saying that they are using the wrong extension.

@gebner
Copy link
Member

gebner commented Jul 18, 2022

It is actually completely supported to have both extensions installed and activated at the same time. I have both installed and it automatically picks the right one depending on the project. Can you give some more info on how to reproduce this bug?

@gebner gebner transferred this issue from leanprover/lean4 Jul 18, 2022
@gebner gebner added the bug Something isn't working label Jul 18, 2022
@EdAyers
Copy link
Contributor Author

EdAyers commented Jul 28, 2022

I get the Watchdog error whenever the lean4 extension is not enabled.

@EdAyers
Copy link
Contributor Author

EdAyers commented Jul 28, 2022

So maybe this should be a core lean issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants