Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source links #6

Closed
hargoniX opened this issue Jan 3, 2022 · 2 comments · Fixed by #46
Closed

Source links #6

hargoniX opened this issue Jan 3, 2022 · 2 comments · Fixed by #46
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@hargoniX
Copy link
Collaborator

hargoniX commented Jan 3, 2022

Every doc-gen declaration has a source link attached (see e.g.: https://leanprover-community.github.io/mathlib_docs/init/core.html#nat), since doc-gen4 should support arbitrary projects we basically want the same feature but with a custom base URL.
@hargoniX hargoniX added enhancement New feature or request help wanted Extra attention is needed labels Jan 3, 2022
@hargoniX hargoniX self-assigned this Jan 9, 2022
@hargoniX hargoniX mentioned this issue Jan 9, 2022
Merged
@hargoniX
Copy link
Collaborator Author

hargoniX commented Jan 14, 2022 •
edited
Loading

This is partially implemented by #19, what is missing is the ability to link packages with arbitrary dependencies, right now only the package itself as well as the compiler get correctly source linked.

@hargoniX hargoniX removed their assignment Jan 16, 2022
@hargoniX hargoniX mentioned this issue Feb 21, 2022
Closed
@hargoniX hargoniX mentioned this issue Mar 6, 2022
Merged
@hargoniX
Copy link
Collaborator Author

hargoniX commented Mar 6, 2022

All packages that provide a github source URL now link properly, if there does end up being need for more we'll have to change this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lake integration leanprover/doc-gen4
1 participant
@hargoniX