Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PPExt functions from IO to CoreM #204

Closed
Kha opened this issue Oct 6, 2020 · 1 comment
Closed

Move PPExt functions from IO to CoreM #204

Kha opened this issue Oct 6, 2020 · 1 comment

Comments

@Kha
Copy link
Member

Kha commented Oct 6, 2020

We currently lose all trace messages when going through the PPExt indirection layer. While the indirection still makes sense even in the new frontend to avoid a dependency cycle, we should change the base monad after removing the old frontend.

@Kha
Copy link
Member Author

Kha commented Oct 15, 2020

I'm closing this since this will simply lead to another dependency cycle: PPExt -> CoreM -> Message -> PPExt. We would have to split at least Message and Util.Trace to circumvent it. It's probably easier to only use direct invocations when testing and tracing the pretty printer.

@Kha Kha closed this as completed Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant