Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax auto-implicit restrictions #1011

Closed
Kha opened this issue Feb 8, 2022 · 3 comments
Closed

Relax auto-implicit restrictions #1011

Kha opened this issue Feb 8, 2022 · 3 comments

Comments

@Kha
Copy link
Member

Kha commented Feb 8, 2022

In the last dev meeting we decided that we can probably lift the restriction of auto-implicits to single-letter lower-case identifiers now that we have semantic highlighting, much like Isabelle does. I did voice the caveat though that because of limitations in the LSP clients, semantic hightlighting currently is updated only after the entire file has been elaborated.

This issue is to document the discussion, and see if there are any further concerns or other comments.

@Kha
Copy link
Member Author

Kha commented Feb 8, 2022

semantic hightlighting currently is updated only after the entire file has been elaborated.

To be more precise, lsp-mode on edit seems to request a highlighting update for the current view, and then for the remaining file (both without support for partial results). So it might not be too bad as long as your current viewport is not that expensive to elaborate. I don't know the behavior of other editors.

@gebner
Copy link
Member

gebner commented Feb 8, 2022

neovim doesn't have semantic highlights yet (probably next release). I haven't found auto-implicits to be confusing without the highlighting.

leodemoura added a commit that referenced this issue Feb 8, 2022
@leodemoura
Copy link
Member

We can disable the feature using set_option relaxAutoImplicit false.
Let's see how confusing the new default is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants