feat: use whnf in ext, more like Lean3 behaviour #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We restore Lean3-like behaviour to ext, by keeping track of two discrimation trees. The first is the current behaviour of
ext, while the second indexes usingwhnf.See leanprover-community/mathlib4#5191 for examples of how this works out in mathlib4. (That PR is far from exhaustive.)
Obviously this will be slower, but I hope it's considered worth it for the simplifications available in mathlib4. Note this is still much faster than the mathlib3 behaviour (where there wasn't any discrimation tree at all, just a single big bucket of lemmas).
applyis fast.