-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cleanup some Nat lemmas #177
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digama0
reviewed
Jul 4, 2023
b35d31f
to
a19f551
Compare
d362c9b
to
f849b35
Compare
Regarding #118: I'm tempted to rename
|
8f59712
to
b580f2f
Compare
I finally opted for |
Potentially breaking changes: * Two parameters of `Nat.lt_add_right` have been made implicit.
Potentially breaking changes: * Changed `Nat.mul_lt_mul`, use `Nat.mul_lt_mul_of_lt_of_le` instead * Deprecated `Nat.mul_lt_mul'` * Deprecated `Nat.mul_le_mul_of_nonneg_left` * Deprecated `Nat.mul_le_mul_of_nonneg_right`
Potentially breaking changes: * Changed `Nat.max_le`, use `Nat.max_le_iff` instead. * Changed `Nat.le_min`, use `Nat.le_min_iff` instead. * Deprecated `Nat.lt_min` * Deprecated `Nat.max_zero` * Deprecated `Nat.min_zero` * Deprecated `Nat.zero_max` * Deprecated `Nat.zero_min`
Potentially breaking changes: * Made parameters implicit for `Nat.add_le_add_iff_left` * Made parameters implicit for `Nat.add_le_add_iff_right` * Made parameters implicit for `Nat.add_lt_add_iff_left` * Made parameters implicit for `Nat.add_lt_add_iff_right` * Made parameters implicit for `Nat.dvd_iff_mod_eq_zero`
Now broken up into smaller pieces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #182
Potentially breaking changes:
Nat.mul_lt_mul
(1 use in Mathlib). See comments below.Nat.lt_add_right
(4 uses in Mathlib)Nat.add_le_add_iff_left
(no uses in Mathlib)Nat.add_le_add_iff_right
(no uses in Mathlib)Nat.add_lt_add_iff_left
(no uses in Mathlib)Nat.add_lt_add_iff_right
(no uses in Mathlib)Nat.dvd_iff_mod_eq_zero
(16 uses in Mathlib)Nat.max_le
(no uses in Mathlib) toNat.max_le_iff
and added newNat.max_le
(Mathlib conformance)Nat.le_min
(no uses in Mathlib) toNat.le_min_iff
and added newNat.le_min
(Mathlib conformance)Nat.zero_le
(unknown uses in Mathlib; at least one hiding clause)Nat.one_pos
(unknown uses in Mathlib)Nat.two_pos
(no uses in Mathlib)Nat.lt_min
(no uses in Mathlib)Nat.add_le_to_le_sub
(no uses in Mathlib)Nat.succ_add_eq_succ_add
(4 uses in Mathlib)Nat.mul_le_mul_of_nonneg_left
(4 uses in Mathlib)Nat.mul_le_mul_of_nonneg_right
(3 uses in Mathlib)Nat.mul_lt_mul'
(2 uses in Mathlib)Nat.zero_max
(1 use in Mathlib)Nat.zero_min
(no uses in Mathlib)Nat.max_zero
(no uses in Mathlib)Nat.min_zero
(no uses in Mathlib)Deprecated lemmas all have recommended replacements.