feat: add alias tactic #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgdorais
force-pushed
the
tac_alias
branch
2 times, most recently
from
3674d65
to
de40d83
Compare
fpvandoorn
approved these changes
Jul 18, 2023
Std/Tactic/Alias.lean
Outdated
|
|
||
| TODO: Move this declaration to a more central location. | ||
| -/ | ||
| def appendNamespace (ns : Name) : Name → Name |
There was a problem hiding this comment.
Maybe this should be moved to a central location in Std? Other than that, LGTM
There was a problem hiding this comment.
or in lean... I know this is reimplemented at least 3 times in lean core
There was a problem hiding this comment.
I'm happy to change this given a pointer to an implementation in core.
There was a problem hiding this comment.
I couldn't find this exact thing in core but I did simplify the definition a bit.
There was a problem hiding this comment.
There is now a PR in core: lean4#2341.
|
I added support for protected aliases and I added a Mathlib patch. |
|
Obsoleted by #200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from Mathlib. Added support for protected aliases.