Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename Nat.coprime to Nat.Coprime #187

Merged
merged 6 commits into from
Sep 14, 2023

Conversation

eric-wieser
Copy link
Member

It's a prop, so should be PascalCase.

Std/Data/Nat/Gcd.lean Outdated Show resolved Hide resolved
Std/Data/Nat/Gcd.lean Outdated Show resolved Hide resolved
@semorrison semorrison added the awaiting-author Waiting for PR author to address issues label Aug 8, 2023
Std/Data/Nat/Gcd.lean Outdated Show resolved Hide resolved
Std/Data/Nat/Gcd.lean Outdated Show resolved Hide resolved
Co-authored-by: François G. Dorais <fgdorais@gmail.com>
Copy link
Collaborator

@fgdorais fgdorais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more.

Std/Data/Nat/Gcd.lean Outdated Show resolved Hide resolved
Std/Data/Nat/Gcd.lean Outdated Show resolved Hide resolved
Std/Data/Nat/Gcd.lean Outdated Show resolved Hide resolved
eric-wieser and others added 3 commits August 20, 2023 19:52
Co-authored-by: François G. Dorais <fgdorais@gmail.com>
@eric-wieser
Copy link
Member Author

@fgdorais: this now builds

@digama0 digama0 merged commit 5e14f63 into leanprover-community:main Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author Waiting for PR author to address issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants