-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: more succ/pred lemmas for Nat
#195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgdorais
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 23, 2023
[ ] Depends on [std4#195](leanprover-community/batteries#195) * Use `Nat.le_sub_one_of_lt` instead of `Nat.le_pred_of_lt`. * New implicit parameter for `Nat.eq_zero_of_nonpos`.
5ee82b1
to
5fddf24
Compare
1 task
5fddf24
to
cb00add
Compare
cb00add
to
b26c3e6
Compare
digama0
reviewed
Nov 1, 2023
digama0
reviewed
Nov 1, 2023
digama0
reviewed
Nov 1, 2023
digama0
approved these changes
Nov 1, 2023
Potentially breaking: * `Nat.le_pred_of_lt` was changed to use `pred` instead of `_-1`; use `Nat.le_sub_one_of_lt` instead * Deprecated `Nat.succ_eq_one_add` * New implicit parameter for `Nat.eq_zero_of_nonpos`
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
d9f122a
to
c9b31d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nat
) mathlib4#6203There are two potentially breaking changes here:
Nat.le_pred_of_lt
was changed to usepred
instead of_-1
andNat.le_sub_one_of_lt
was added as a replacement.Nat.eq_zero_of_nonpos
.