Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more succ/pred lemmas for Nat #195

Merged
merged 6 commits into from
Nov 4, 2023

Conversation

fgdorais
Copy link
Collaborator

@fgdorais fgdorais commented Jul 23, 2023

There are two potentially breaking changes here:

  • Nat.le_pred_of_lt was changed to use pred instead of _-1 and Nat.le_sub_one_of_lt was added as a replacement.
  • Implicit parameters for Nat.eq_zero_of_nonpos.

fgdorais added a commit to leanprover-community/mathlib4 that referenced this pull request Jul 23, 2023
[ ] Depends on [std4#195](leanprover-community/batteries#195)

* Use `Nat.le_sub_one_of_lt` instead of `Nat.le_pred_of_lt`.
* New implicit parameter for `Nat.eq_zero_of_nonpos`.
@fgdorais fgdorais force-pushed the nat-succ-pred branch 3 times, most recently from 5ee82b1 to 5fddf24 Compare July 24, 2023 11:19
@fgdorais fgdorais added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Aug 21, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Sep 25, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Oct 31, 2023
Std/Data/Nat/Lemmas.lean Outdated Show resolved Hide resolved
Std/Data/Nat/Lemmas.lean Outdated Show resolved Hide resolved
Std/Data/Nat/Lemmas.lean Outdated Show resolved Hide resolved
fgdorais and others added 6 commits November 4, 2023 18:00
Potentially breaking:

* `Nat.le_pred_of_lt` was changed to use `pred` instead of `_-1`; use `Nat.le_sub_one_of_lt` instead
* Deprecated `Nat.succ_eq_one_add`
* New implicit parameter for `Nat.eq_zero_of_nonpos`
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@digama0 digama0 merged commit 8bedddc into leanprover-community:main Nov 4, 2023
1 check passed
@fgdorais fgdorais deleted the nat-succ-pred branch November 5, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review This PR is ready for review; the author thinks it is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants