Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upstream pickle #211

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Conversation

semorrison
Copy link
Collaborator

No description provided.

@semorrison semorrison added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Aug 8, 2023
Copy link
Collaborator

@fgdorais fgdorais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking about doing this one, so I think this is a good idea! The API from Mathlib is clean and clear, no need for additional changes from my perspective.

@digama0 digama0 merged commit b6af7aa into leanprover-community:main Aug 19, 2023
1 check passed
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Aug 21, 2023
The file [`Mathlib.Util.Pickle`](leanprover-community/batteries#211) has been upstreamed to std4, as has the declaration [`String.count`](leanprover-community/batteries#220).



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review This PR is ready for review; the author thinks it is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants