chore: upstream on_goal / pick_goal / swap #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 6, 2023
semorrison
added
the
awaiting-review
|
I think this needs more justification. I can see this is of some use but I'm wondering why structured proofs don't solve most of the use cases. Some parts would be handy for writing basic tactics that need to reorder goals but there are other ways to do that. Bottom line, this looks like legacy Lean 3 code for the most part. I would like to see a less complicated API and more convincing test cases. |
|
I believe the motivation is at least in part so that they can be generated by tools like |
|
I understand now. Also, the tests for #242 are exactly the kind of use cases I was looking for. I approve. |
fgdorais
approved these changes
Nov 7, 2023
joehendrix
approved these changes
Nov 27, 2023
joehendrix
added
will-merge-soon
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 28, 2023
- [x] depends on: leanprover-community/batteries#241 Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
awueth
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 19, 2023
- [x] depends on: leanprover-community/batteries#241 Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.