feat: ensure HashMap computes in the kernel #390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
awaiting-review
JamesGallicchio
approved these changes
Nov 24, 2023
digama0
reviewed
Nov 24, 2023
|
|
||
| -- Verify that basic operations are computable in the kernel, and not blocked by | ||
| -- `System.Platform.numBits`. | ||
| example : (HashMap.empty.insert 0 0).isEmpty = false := rfl |
|
Note, this PR may be rejected or modified pending discussion on Zulip. |
|
Yes, I agree this is a bad idea now. Thanks for the explanations, very helpful. (Sadly, using RBMap in my application turned out to be even slower that just traversing lists...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems a poor tradeoff to eke out a little more performance at the cost of losing the ability to compute with
HashMapin the kernel.