chore: moreServerOptions instead of moreServerArgs #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tydeu, could you please review? |
semorrison
added
the
awaiting-review
|
I'll need to make the corresponding change at Mathlib, but will wait until this has been reviewed. |
|
The new version of lake supports |
tydeu
approved these changes
Nov 29, 2023
semorrison
added a commit
that referenced
this pull request
Nov 30, 2023
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
semorrison
added a commit
that referenced
this pull request
Nov 30, 2023
* chore: bump for lean v4.4.0 Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Richard Copley <buster@buster.me.uk> Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com> Co-authored-by: Mauricio Collares <mauricio@collares.org> * chore: leanOptions instead of moreServerArgs (#406) Co-authored-by: Mario Carneiro <di.gama@gmail.com> * chore: bump toolchain to v4.4.0-rc1 --------- Co-authored-by: Marc Huisinga <mhuisi@protonmail.com> Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Richard Copley <buster@buster.me.uk> Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com> Co-authored-by: Mauricio Collares <mauricio@collares.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to the
bump/v4.4.0, updating thelakefile.leanto account for a deprecated option.It is slightly clunky that we need the
.map (·.asCliArg)step to translate frommoreServerOptionstomoreLeanArgs.