Revert "feat: add support for not-in in exists (#425)" #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit c4ece13.
|
The commit broke mathlib. The breakage can be observed in leanprover-community/mathlib4#8888. The error message is: elaboration function for 'Std.ExtendedBinder.«termSatisfies_binder_pred%__»' has not been implemented
satisfies_binder_pred% i ∉ s@Ruben-VandeVelde suggested to revert his commit, so this PR implements the revert. |
3 tasks
|
Do you have a failing test case? |
See the last comments in leanprover-community/mathlib4#8888. |
|
That's just saying there is a problem, it's not suitable as a test case. |
|
It seems the issue is that this binder predicate is already defined in |
|
Thank you, @digama0. |
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 8, 2023
Since this bump does not include leanprover-community/batteries#427 (in order to avoid having to handle the intermediate commits all at once), we temporarily remove the single use of a `∀ i ∉ s,` binder, and the two tests of it. We can revert these changes in a later Std bump, once we've address the other awkward bumps inbetween. This unblocks #8711.
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 11, 2023
…tteries#427 (#8888) Co-authored-by: James <jamesgallicchio@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Siddharth Bhat <siddu.druid@gmail.com>
awueth
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 19, 2023
Since this bump does not include leanprover-community/batteries#427 (in order to avoid having to handle the intermediate commits all at once), we temporarily remove the single use of a `∀ i ∉ s,` binder, and the two tests of it. We can revert these changes in a later Std bump, once we've address the other awkward bumps inbetween. This unblocks #8711.
awueth
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 19, 2023
…tteries#427 (#8888) Co-authored-by: James <jamesgallicchio@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Siddharth Bhat <siddu.druid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c4ece13 (#425), which accidentally added a binder predicate that was already defined in Std.Classes.SetNotation.