Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate Int.ofNat_natAbs_eq_of_nonneg #432

Merged
merged 3 commits into from Dec 15, 2023

Conversation

semorrison
Copy link
Collaborator

Fixes #419.

@semorrison semorrison added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Dec 12, 2023
Std/Data/Int/Lemmas.lean Outdated Show resolved Hide resolved
@joehendrix joehendrix added awaiting-author Waiting for PR author to address issues and removed awaiting-review This PR is ready for review; the author thinks it is ready to be merged. labels Dec 12, 2023
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@semorrison semorrison added awaiting-review This PR is ready for review; the author thinks it is ready to be merged. and removed awaiting-author Waiting for PR author to address issues labels Dec 12, 2023
@joehendrix joehendrix removed the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Dec 15, 2023
@joehendrix joehendrix merged commit 9dd24a3 into main Dec 15, 2023
2 checks passed
@joehendrix joehendrix deleted the deprecate_ofNat_natAbs_eq_of_nonneg branch December 15, 2023 17:26
semorrison added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 16, 2023
mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Dec 17, 2023
This covers these changes in Std: leanprover-community/batteries@6b4cf96...9dd24a3

* `Int.ofNat_natAbs_eq_of_nonneg` has become `Int.natAbs_of_nonneg` (and one argument has become implicit)
* `List.map_id''` and `List.map_id'` have exchanged names. (Yay naming things using primes!)
* Some meta functions have moved to Std and can be deleted here.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Dec 17, 2023
This covers these changes in Std: leanprover-community/batteries@6b4cf96...9dd24a3

* `Int.ofNat_natAbs_eq_of_nonneg` has become `Int.natAbs_of_nonneg` (and one argument has become implicit)
* `List.map_id''` and `List.map_id'` have exchanged names. (Yay naming things using primes!)
* Some meta functions have moved to Std and can be deleted here.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
awueth pushed a commit to leanprover-community/mathlib4 that referenced this pull request Dec 19, 2023
This covers these changes in Std: leanprover-community/batteries@6b4cf96...9dd24a3

* `Int.ofNat_natAbs_eq_of_nonneg` has become `Int.natAbs_of_nonneg` (and one argument has become implicit)
* `List.map_id''` and `List.map_id'` have exchanged names. (Yay naming things using primes!)
* Some meta functions have moved to Std and can be deleted here.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Int.ofNat_natAbs_eq_of_nonneg and Int.natAbs_of_nonneg seem duplicates
3 participants