feat: "Try this:" custom code action title #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awaiting-review |
github-actions
bot
added
the
awaiting-review
semorrison
approved these changes
Dec 19, 2023
joehendrix
added
will-merge-soon
semorrison
added a commit
that referenced
this pull request
Dec 21, 2023
commit 74d2899 Author: Wojciech Nawrocki <wjnawrocki@protonmail.com> Date: Sun Dec 17 01:56:41 2023 +0100 chore: set toolchain commit 3f88f41 Author: Wojciech Nawrocki <wjnawrocki@protonmail.com> Date: Sun Dec 17 01:52:45 2023 +0100 feat: adapt TryThis Revert "feat: "Try this:" custom code action title (#466)" This reverts commit 455498d.
semorrison
added a commit
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the code action title in the lightbulb menu is hardcoded to
Try this: <prettyPrintedSuggestionText>. This needs to be customized in various cases, such as teaching in non-English languages. This PR:toCodeActionTitle? : Option (String -> String)toSuggestion, which, if provided, can be applied to the pretty-printed suggestion text and transform it as desired (note that this application occurs prior to encoding, so we only pass the resulting code action titleString, if any, to the Json version of theSuggestionstructure; note also that we don't want to pretty-print twice, so we take in the pretty-printedStringas an argument instead of theSuggestionTextitself)codeActionPrefix? : Option String := nonetoaddSuggestionsto conveniently provide a default code action title prefix to use for all elements in anArray Suggestionwhich do not have a nontrivialtoCodeAction?value.See zulip for the feature request and discussion on the choice of default behavior.