chore: remove triv tactic #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
awaiting-review
digama0
reviewed
Mar 26, 2024
digama0
added
will-merge-soon
|
approved pending merge of the mathlib4 PR. |
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 26, 2024
Std defines `triv`, a slight variation on `trivial`. It appears that Mathlib doesn't care about the distinction (any more?) and so we can consolidate on a single tactic. leanprover-community/batteries#712 separately replaces `triv` in Std with an error explaining to use `trivial`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Louddy
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 15, 2024
Std defines `triv`, a slight variation on `trivial`. It appears that Mathlib doesn't care about the distinction (any more?) and so we can consolidate on a single tactic. leanprover-community/batteries#712 separately replaces `triv` in Std with an error explaining to use `trivial`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
atarnoam
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 16, 2024
Std defines `triv`, a slight variation on `trivial`. It appears that Mathlib doesn't care about the distinction (any more?) and so we can consolidate on a single tactic. leanprover-community/batteries#712 separately replaces `triv` in Std with an error explaining to use `trivial`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
uniwuni
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 19, 2024
Std defines `triv`, a slight variation on `trivial`. It appears that Mathlib doesn't care about the distinction (any more?) and so we can consolidate on a single tactic. leanprover-community/batteries#712 separately replaces `triv` in Std with an error explaining to use `trivial`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
callesonne
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 22, 2024
Std defines `triv`, a slight variation on `trivial`. It appears that Mathlib doesn't care about the distinction (any more?) and so we can consolidate on a single tactic. leanprover-community/batteries#712 separately replaces `triv` in Std with an error explaining to use `trivial`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not used in Mathlib; all uses can just become
trivial. Let's remove the unnecessary duplication.leanprover-community/mathlib4#11679