chore: de-mathlib lots of Data/List/Lemmas.lean #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
okay, I made mostly style and golfing changes, but also some renames. For I will merge shortly if there are no objections. |
digama0
approved these changes
Feb 1, 2023
JamesGallicchio
commented
Feb 1, 2023
|
Also just realized there's some |
|
if the attributes can be added after the fact in mathlib (which I think is the case), then it's fine to remove the comments. The mathlib4 PR will have standalone |
JamesGallicchio
force-pushed
the
chore/move-list-lemmas
branch
from
c359d52
to
f05bb95
Compare
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 27, 2023
Notably incorporates leanprover-community/batteries#98 and leanprover-community/batteries#109. leanprover-community/batteries#98 moves a number of lemmas from Mathlib to Std, so the bump requires deleting them in Mathlib. I did check on each lemma whether its attributes were kept in the move (and gave attribute markings in Mathlib if they were not present in Std), but a reviewer may wish to re-check. `List.mem_map` changed statement from `b ∈ l.map f ↔ ∃ a, a ∈ l ∧ b = f a` to `b ∈ l.map f ↔ ∃ a, a ∈ l ∧ f a = b`. Similarly for `List.exists_of_mem_map`. This was a deliberate change, so I have simply adjusted proofs (many become simpler, which supports the change). I also deleted `List.mem_map'`, `List.exists_of_mem_map'`, which were temporary versions in Mathlib while waiting for this change (replacing their uses with the unprimed versions). Also, the lemma `sublist_nil_iff_eq_nil` seems to have been renamed to `sublist_nil` during the move, so I added an alias for the old name. (another issue fixed during review by @digama0) ~~`List.Sublist.filter` had an argument change from explicit to implicit. This appears to have been an oversight (cc @JamesGallicchio). I have temporarily introduced `List.Sublist.filter'` with the argument explicit, and replaced Mathlib uses of `Sublist.filter` with `Sublist.filter'`. Later we can fix the argument in Std, and then delete `List.Sublist.filter'`.~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe all the statements are pulled from mathlib4 identically.
Main weirdness is Std had a
mem_maplemma with a conclusion that is in some sense backwards from what would generally be preferred. Mathlib has amem_map'for porting, so I moved themem_map'lemma here. We might want to deprecatemem_map.Depends on #97.