Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detailed description for each type of proposal #72

Closed
5 tasks
troggy opened this issue Dec 3, 2018 · 17 comments
Closed
5 tasks

Add more detailed description for each type of proposal #72

troggy opened this issue Dec 3, 2018 · 17 comments

Comments

@troggy
Copy link
Member

troggy commented Dec 3, 2018

Governance proposals are changes to the plasma contract that are held for 7 days before applied to the contract. They are displayed for all users to see on testnet and mainnet.

Add more detailed description for each type of proposal, so that it is easier to understand the consequence of the change

Scope

  • for each of the possible governance parameter change, show the human-friendly description (maybe hidden by default to reduce noise for power users) on how the parameter affects the network.
  • distinguish between different contract upgrade proposals (operator, exitHandler, bridge, swapRegistry). Again, use human-friendly description
  • show link to the contract code for contract upgrade proposals — maybe just a link to the repo for now until we have something like https://github.com/leapdao/network-governance/issues/17 implemented)
  • show link to the contract code for governance upgrade proposals
  • show basic token information (name, ticker, NFT or not, link to etherscan) for register token proposals

Bounty setup

gardener: @troggy / 10%
worker: ___ / 70%
reviewer: ___ / 20%

@sunify sunify changed the title Governance: add more detailed description for each type of proposal Add more detailed description for each type of proposal Dec 10, 2018
@troggy troggy added the size-M effort of ~8h label Dec 26, 2018
@troggy troggy added this to Proposed in Bounties Dec 26, 2018
@troggy troggy moved this from Proposed to Available in Bounties Dec 30, 2018
@johannbarbie johannbarbie added this to the 🚣 1.0 The Raft milestone Jan 11, 2019
@troggy troggy assigned troggy and unassigned troggy Jan 12, 2019
@troggy troggy added the bounty label Mar 5, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 350.0 DAI (350.0 USD @ $1.0/DAI) attached to it as part of the leapdao fund.

@gitcoinbot
Copy link

@aerophile Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@troggy
Copy link
Member Author

troggy commented Apr 5, 2019

@aerophile howdy 👋

how is the progress so far, need any hints?

@aerophile
Copy link

hey @troggy ok so far. Still on initial research. Will ping for hints soon

@gitcoinbot
Copy link

@aerophile Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@aerophile
Copy link

I am working on this @gitcoinbot

@gitcoinbot
Copy link

@aerophile Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@troggy
Copy link
Member Author

troggy commented Apr 17, 2019

@aerophile we need to see signs of work here please — work in progress PR or at least communication about the issue. Otherwise, we'll withdraw the issue from you by tomorrow end of the day.

@aerophile
Copy link

aerophile commented Apr 18, 2019

Hey @troggy

I was going through Leapdao docs and playing around with the testnet and mainnet, really impressed as this is my first experience with plasma. I also now understand governance proposals, I'd like to know, How can I lets say create a proposal on testnet. One way could be to put in a request to register a new token.

There's already one register token request on the mainnet but I'd like to make a few different proposals on the testnet and then work on adding the descriptions.

Also are you on leapDAO slack ?

@troggy
Copy link
Member Author

troggy commented Apr 19, 2019

@aerophile yes, I'm kosta on a LeapDAO slack

@gitcoinbot
Copy link

@aerophile Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@aerophile Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@aerophile due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@aerophile
Copy link

An update so far:. I was not as familiar with plasma so was going through docs at learnplasma.org and leapdao docs. I also joined the leapdao slack and then also got to know about that to create the governance proposals on the testnet, I can ask some a few specific people with signing authority. RIght now I'm going through bridge-ui's code to understand what would be modified for detecting different types of governanace proposals and the proposed changes in them. Once this is done, I will discuss the specific human firiendly change to show. Please do reach out on slack or here incase of questions for me.

@gitcoinbot
Copy link

gitcoinbot commented May 21, 2019

Issue Status: 1. Open 2. Cancelled


Workers have applied to start work.

These users each claimed they can complete the work by 2 years, 8 months ago.
Please review their action plans below:

1) vikasvmads has applied to start work (Funders only: approve worker | reject worker).

Hi, Please add my interest work for this project.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Cancelled


The funding of 350.0 DAI (350.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

@troggy
Copy link
Member Author

troggy commented Sep 24, 2019

old and rusty

@troggy troggy closed this as completed Sep 24, 2019
@johannbarbie johannbarbie moved this from Available to Ready for review in Bounties Oct 14, 2019
@johannbarbie johannbarbie moved this from Ready for review to Done in Bounties Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

5 participants