Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested additional test - drake - find_or_create_by_name #18

Closed
jonbf opened this issue Nov 16, 2016 · 2 comments
Closed

Suggested additional test - drake - find_or_create_by_name #18

jonbf opened this issue Nov 16, 2016 · 2 comments
Labels

Comments

@jonbf
Copy link

jonbf commented Nov 16, 2016

for drake_made_this, i would suggest adding a test that fails if the student tries:

def drake_made_this
# when this method is called it should assign the song's artist to Drake
self.artist = Artist.new(name: "Drake")
end
end

@curiositypaths
Copy link
Contributor

Thanks for reporting this issue. We're now aware of it and are tracking it in
#23. We will add this to our internal work queue and
notify you when it is resolved.

We're closing this issue but invite you to follow progress at that URL.

-- Flatiron Curriculum Team

@maxwellbenton
Copy link
Contributor

Hi @jonbf,

Thank you for opening this issue and providing feedback. We've updated the tests in this lesson to test for the presence of a new Artist instance, so this solution will no longer pass the tests.

Thank you for contributin to a Learn lesson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@curiositypaths @jonbf @maxwellbenton and others