Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly inaccurate information about grid-area in the README #4

Closed
Sdcrouse opened this issue Jul 15, 2020 · 1 comment
Closed

Possibly inaccurate information about grid-area in the README #4

Sdcrouse opened this issue Jul 15, 2020 · 1 comment

Comments

@Sdcrouse
Copy link

At the end of the "grid-column, grid-row and grid-area" section, the README says:

Remember how it is possible to give names to lines using our grid-template properties? This is where these names become useful. If we had names for the beginning and end rows of a page footer, for instance, we could declare a grid-area for our footer as:

grid-area: footer-start / 1 / footer-end / 4

This would start our area wherever the line footer-start is defined in our row template, and end wherever footer-end is defined. In a complex grid, taking the time to name important lines in your layout makes it easier to position grid elements to them without having to look up or count the number of lines.

I tried out something similar, but with header-start and header-end (which were used earlier in the README). I didn't see any changes when I refreshed the index.html page.

I think that line of code needs to be changed to grid-area: footer. I found a related tutorial from the MDN documentation that goes into this: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout/Layout_using_Named_Grid_Lines#Implicit_grid_areas_from_named_lines

Hope that helps!

Sdcrouse

@lizbur10
Copy link
Contributor

Closing as outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants