Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNOWN ISSUE: so return NaN passes the deleteFromDriverByKey test? #10

Closed
arye-eidelman opened this issue Aug 29, 2018 · 1 comment
Closed

Comments

@arye-eidelman
Copy link

function deleteFromDriverByKey(driver, key){
  return NaN 
}
// why does this pass the test 

This is what I actually tried and it passed the test just fine without me realizing that it was actually returning NaN

function deleteFromDriverByKey(driver, key){
  return driver - driver[key]  // NaN 
}

Only when I went to the next function and tried a similar answer which didn't work did I open up the debugger and realize that it was returning NaN

function destructivelyDeleteFromDriverByKey(driver, key){
  driver -= key
  return driver
}
@drakeltheryuujin drakeltheryuujin changed the title so return NaN passes the deleteFromDriverByKey test? KNOWN ISSUE: so return NaN passes the deleteFromDriverByKey test? Sep 25, 2018
@drakeltheryuujin
Copy link

Thanks for reporting this issue. We're now aware of it and are tracking it in
#11. We will add this to our internal work queue and
notify you when it is resolved.

We're closing this issue but invite you to follow progress at that URL.

-- Flatiron Curriculum Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@drakeltheryuujin @arye-eidelman and others