Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models are not set up #1

Closed
Matt-Eva opened this issue Dec 29, 2022 · 4 comments
Closed

Models are not set up #1

Matt-Eva opened this issue Dec 29, 2022 · 4 comments
Assignees
Labels
se curriculum Issue for lessons in the Software Engineering program se-python Issue for Python/Flask lessons

Comments

@Matt-Eva
Copy link

Canvas Link

https://learning.flatironschool.com/courses/6182/assignments/211188?module_item_id=486871

Concern

Our instructions indicate that the models are already set up for students, and that all they have to do is run alembic upgrade head. We actually haven't filled out any information for the models thus far. Also our directions are weirdly worded:

This project has starter code for a couple of models, Author and Post. To get set up, run:

This is a test-driven lab. Run pipenv install to create your virtual environment and pipenv shell to enter the virtual environment.

To generate a database using the provided models, from lib/ run:

$ alembic upgrade head

Additional Context

No response

Suggested Changes

No response

@Matt-Eva Matt-Eva added the se curriculum Issue for lessons in the Software Engineering program label Dec 29, 2022
@Matt-Eva
Copy link
Author

Also, we don't instruct students as to what columns they should be adding to their models, or what datatypes those columns should use. I imagine that this is due to the fact that we were planning on having the models built out for them, but if we want them to build out their own models, we'll probably want to give them those details.

@pgill97
Copy link
Contributor

pgill97 commented Jan 6, 2023

@professor-ben Holding off on this issue because I will change the SQLAlchemy validation stuff to use Flask-sqlalchemy then I will update this lab.

@lizbur10 lizbur10 added the se-python Issue for Python/Flask lessons label Jan 11, 2023
@pgill97 pgill97 closed this as completed Mar 16, 2023
@sheenasany sheenasany reopened this Apr 11, 2023
@sheenasany
Copy link

sheenasany commented Apr 11, 2023

Opening this one back up again because the previous issue of the instructions stating that the lab has starter code for the Author and Post models is still not true. When opening the lab the models are empty. There is also no instruction as to what datatypes the columns should be as Matt stated previously.

Please either include the starter code or include instructions on what to add for the models before running flask db upgrade. Currently there are no migrations created, so they would need to run flask db revision --autogenerate -m "<your comment>" beforehand as well in order to run the migrations. Otherwise the tests will fail.

Order of operations:

  • Have starter code for the models already set up || include instructions on what to include for each column of the models to build out
  • Run flask db revision --autogenerate -m "<your comment>"
  • Then run flask db upgrade
  • Then run pytest and continue the lab as instructed.

@pgill97
Copy link
Contributor

pgill97 commented Apr 17, 2023

Added starter code to models and instructions on creating a migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
se curriculum Issue for lessons in the Software Engineering program se-python Issue for Python/Flask lessons
Projects
None yet
Development

No branches or pull requests

4 participants