Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tests for the API fetching section #11

Closed
kjleitz opened this issue Jun 19, 2017 · 3 comments
Closed

Missing tests for the API fetching section #11

kjleitz opened this issue Jun 19, 2017 · 3 comments

Comments

@kjleitz
Copy link
Contributor

kjleitz commented Jun 19, 2017

There are no tests for the NYT movie reviews API, despite a section for it in the README and some pre-existing code related to it in LatestMovieReviewsContainer.js. All tests pass without ever touching fetch or the API itself.

@FreeBreadsticks
Copy link

I noticed the same thing - I was a little confused by it at first!

@dkStephanos
Copy link

Still unresolved!!

@maxwellbenton
Copy link
Contributor

Thank you for providing this feedback.

We have updated the materials and included fetch tests to make sure calls are being made to the NYT API, and believe your issue to have been resolved.

We apologize for any frustration you might have encountered during this process but thank you for helping us ensure that those who follow in your path will not encounter the same problems that you faced.

If you do not believe that this issue has been addressed, please re-open this issue. 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@FreeBreadsticks @kjleitz @maxwellbenton @dkStephanos and others