Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No browser output #14

Closed
dkStephanos opened this issue Feb 6, 2018 · 1 comment
Closed

No browser output #14

dkStephanos opened this issue Feb 6, 2018 · 1 comment

Comments

@dkStephanos
Copy link

Aside from the fact that this lab doesn't actually use the API or fetch calls it refers to, it renders nothing in the browser. It would be nice if the API section was tested in such a way that you actually see data in the browser. As of right now, you just get a bunch of tests to pass, and nothing functions or renders... hardly a strong, realistic example.

@maxwellbenton
Copy link
Contributor

Thank you for providing this feedback.

We have updated the materials and to make sure this lab will correctly render in browser when all tests have passed, and included fetch tests to make sure calls are being made to the NYT API, and believe your issue to have been resolved.

We apologize for any frustration you might have encountered during this process but thank you for helping us ensure that those who follow in your path will not encounter the same problems that you faced.

If you do not believe that this issue has been addressed, please re-open this issue. 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@maxwellbenton @dkStephanos and others