Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear instructions? #11

Closed
meryldakin opened this issue Aug 29, 2017 · 1 comment
Closed

Unclear instructions? #11

meryldakin opened this issue Aug 29, 2017 · 1 comment
Labels
Curriculum

Comments

@meryldakin
Copy link

  1. The onSubmit callback prop should only be called if both fields are filled in (with any value).

This makes it sound like they need a ternary in the onSubmit property of the button to only call this.handleSubmit if the conditions are met. I don't THINK that's the intention but I could be wrong. If I'm correct, I would suggest wording it like this:

  1. The callback prop passed to the component should only be called if both fields are filled in (with any value).
@realAndrewCohn
Copy link
Contributor

The readme has been updated to be clearer closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Curriculum
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@realAndrewCohn @meryldakin and others