Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail if requirements are met for login form #23

Closed
tpetersen0308 opened this issue Jul 11, 2018 · 1 comment
Closed

Tests fail if requirements are met for login form #23

tpetersen0308 opened this issue Jul 11, 2018 · 1 comment
Labels

Comments

@tpetersen0308
Copy link

Lines 62 and 99 of LoginForm-test.js test that it is true that:

"The default form action is not being prevented when the form is submitted" (line 62)

"The onSubmit prop is not being called" (line 99)

But the lab requires that the default form action IS prevented and the onSubmit prop IS called, resulting in conflicts that make the tests unpassable. Changing these to false gets tests passing. Confirmed in the browser.

@maxwellbenton
Copy link
Contributor

Thank you for spotting this issue and providing feedback.

We have updated the tests for this lab and believe your issue to have been resolved.

We apologize for any frustration you might have encountered during this process but thank you for helping us ensure that those who follow in your path will not encounter the same problems that you faced.

If you do not believe that this issue has been addressed, please re-open this issue. 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants
@maxwellbenton @tpetersen0308 and others