Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't run tests without running npm install --save raf #26

Closed
DGMarkel opened this issue Nov 18, 2018 · 1 comment
Closed

Can't run tests without running npm install --save raf #26

DGMarkel opened this issue Nov 18, 2018 · 1 comment
Labels

Comments

@DGMarkel
Copy link

DGMarkel commented Nov 18, 2018

I opened this lab and ran learn immediately. Without making any changes to my cloned repo, the tests threw a bunch of errors and wouldn't run.

A quick google search led to the following solution:
npm install --save raf
Then as your first import in entry point, before React:
import 'raf/polyfill';

but it appears that just installing --save raf was enough to get the tests running.

@maxwellbenton
Copy link
Contributor

Hi @DGMarkel,

Thank you for providing this feedback. We've recently changed the package.json file and removed some dependencies that were causing issues. We've confirmed that the current set up is working as expected and will work out of the box.

We apologize for any frustration this may have caused, but thank you for contributing to this lesson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants
@maxwellbenton @DGMarkel and others