Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxChars set to 10 #8

Closed
mikemerin opened this issue Jun 6, 2017 · 1 comment
Closed

maxChars set to 10 #8

mikemerin opened this issue Jun 6, 2017 · 1 comment
Labels

Comments

@mikemerin
Copy link

Unless we look closely at the test, we wouldn't know the maxChars is 10 vs. the normal 140 Twitter uses. This should be stated in the directions.

@Lukeghenco
Copy link
Contributor

Hi @mikemerin, thank you for raising the issue. The idea with this test is to assume you could add any amount of characters in the form, but it can't exceed it. Since it is sent down as a prop it could be 1000, as this is just a dynamic value. That is why we didn't add a specific requirement in the lesson that it had to have a required PropType with a specific length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants
@Lukeghenco @mikemerin and others